[agent/claude] Update the migration plan at docs/plans/2026-03-21-mcp-sdk-m... #4

Closed

Virgil wants to merge 0 commits from agent/update-the-migration-plan-at-docs-plans into dev

Virgil commented

2026-03-21 12:34:33 +00:00

Member

Task

Update the migration plan at docs/plans/2026-03-21-mcp-sdk-migration.md.

The import migration from forge.lthn.ai/core/go to dappco.re/go/core is ALREADY DONE (committed). Now update the plan to:

Read ALL current .go source files in pkg/mcp/ to understand the ACTUAL current state (imports are now dappco.re/go/core)
Read the existing plan at docs/plans/2026-03-21-mcp-sdk-migration.md
Read the CoreGO framework docs at docs/ to understand the AX patterns (Options, Result, Service DTOs)
Update the plan to align with CoreGO's AX conventions:
- Options{} instead of functional options
- Result{} instead of (value, error)
- Service{} DTOs instead of factory functions
- Predictable names, comments as usage examples
The mcp-go SDK is at github.com/mark3labs/mcp-go — check its docs for the API
Key goal: after migration we need SendNotificationToAllClients() and claude/channel experimental capability for pushing events into Claude Code sessions
Write the updated plan back to docs/plans/2026-03-21-mcp-sdk-migration.md

The plan should be executable by agents — specific files, specific changes, build verification steps.

Agent: claude
Commits: 1
Branch: agent/update-the-migration-plan-at-docs-plans

Auto-created by core-agent dispatch system.
Co-Authored-By: Virgil virgil@lethean.io

## Task Update the migration plan at docs/plans/2026-03-21-mcp-sdk-migration.md. The import migration from forge.lthn.ai/core/go to dappco.re/go/core is ALREADY DONE (committed). Now update the plan to: 1. Read ALL current .go source files in pkg/mcp/ to understand the ACTUAL current state (imports are now dappco.re/go/core) 2. Read the existing plan at docs/plans/2026-03-21-mcp-sdk-migration.md 3. Read the CoreGO framework docs at docs/ to understand the AX patterns (Options, Result, Service DTOs) 4. Update the plan to align with CoreGO's AX conventions: - Options{} instead of functional options - Result{} instead of (value, error) - Service{} DTOs instead of factory functions - Predictable names, comments as usage examples 5. The mcp-go SDK is at github.com/mark3labs/mcp-go — check its docs for the API 6. Key goal: after migration we need SendNotificationToAllClients() and claude/channel experimental capability for pushing events into Claude Code sessions 7. Write the updated plan back to docs/plans/2026-03-21-mcp-sdk-migration.md The plan should be executable by agents — specific files, specific changes, build verification steps. **Agent:** claude **Commits:** 1 **Branch:** `agent/update-the-migration-plan-at-docs-plans` --- Auto-created by core-agent dispatch system. Co-Authored-By: Virgil <virgil@lethean.io>

Virgil added 4 commits 2026-03-21 12:34:33 +00:00

chore: sync dependencies for v0.3.3 45fbe0bc73

Co-Authored-By: Virgil <virgil@lethean.io>

chore: sync dependencies for v0.3.4 bac5b83cbf

Co-Authored-By: Virgil <virgil@lethean.io>

refactor: migrate core import to dappco.re/go/core 4c6c9d7709

Co-Authored-By: Virgil <virgil@lethean.io>

docs(mcp): add SDK migration plan for AX conventions + notifications ea81084058

5-phase plan covering:
- Options{} struct replacing functional options (breaking)
- SendNotificationToAllClients + claude/channel capability
- Usage-example comments on all public types
- Notifier interface for subsystem event broadcasting
- Consumer migration guide for agent/ide modules

Evaluated mark3labs/mcp-go vs official SDK; recommends staying on
official SDK with Server.Sessions() wrapper for notifications.

Co-Authored-By: Virgil <virgil@lethean.io>

Virgil commented

2026-03-21 12:34:38 +00:00

Author

Member

Verification Failed

Command: go test ./...

?   	forge.lthn.ai/core/mcp/cmd/brain-seed	[no test files]
?   	forge.lthn.ai/core/mcp/cmd/core-mcp	[no test files]
?   	forge.lthn.ai/core/mcp/cmd/mcpcmd	[no test files]
# forge.lthn.ai/core/mcp/pkg/mcp [forge.lthn.ai/core/mcp/pkg/mcp.test]
pkg/mcp/tools_process_ci_test.go:18:52: cannot use c (variable of type *"dappco.re/go/core".Core) as *"forge.lthn.ai/core/go/pkg/core".Core value in argument to process.NewService(process.Options{})
FAIL	forge.lthn.ai/core/mcp/pkg/mcp [build failed]
?   	forge.lthn.ai/core/mcp/pkg/mcp/agentic	[no test files]
ok  	forge.lthn.ai/core/mcp/pkg/mcp/brain	0.511s
ok  	forge.lthn.ai/core/mcp/pkg/mcp/ide	2.776s
FAIL

Exit code: 1

## Verification Failed **Command:** `go test ./...` ``` ? forge.lthn.ai/core/mcp/cmd/brain-seed [no test files] ? forge.lthn.ai/core/mcp/cmd/core-mcp [no test files] ? forge.lthn.ai/core/mcp/cmd/mcpcmd [no test files] # forge.lthn.ai/core/mcp/pkg/mcp [forge.lthn.ai/core/mcp/pkg/mcp.test] pkg/mcp/tools_process_ci_test.go:18:52: cannot use c (variable of type *"dappco.re/go/core".Core) as *"forge.lthn.ai/core/go/pkg/core".Core value in argument to process.NewService(process.Options{}) FAIL forge.lthn.ai/core/mcp/pkg/mcp [build failed] ? forge.lthn.ai/core/mcp/pkg/mcp/agentic [no test files] ok forge.lthn.ai/core/mcp/pkg/mcp/brain 0.511s ok forge.lthn.ai/core/mcp/pkg/mcp/ide 2.776s FAIL ``` **Exit code:** 1