refactor: remove empty register() methods in Boot classes #33

Open

Charon wants to merge 1 commit from feat/clean-empty-register into dev

Charon commented

2026-03-24 16:41:47 +00:00

Member

Fixes #17

Summary

Removed empty register(): void override from src/Mod/Hub/Boot.php
Removed empty register(): void override from src/Website/Hub/Boot.php

These Boot classes use the event-driven $listens pattern where registration happens in event handlers (onAdminPanel, onDomainResolving), not in register(). The empty overrides served no purpose since the parent ServiceProvider already provides the method.

The two other Boot files were left as-is:

src/Boot.php — has a real register() implementation (module paths + search singleton)
Service/Boot.php — has no register() method at all

Fixes #17 ## Summary - Removed empty `register(): void` override from `src/Mod/Hub/Boot.php` - Removed empty `register(): void` override from `src/Website/Hub/Boot.php` These Boot classes use the event-driven `$listens` pattern where registration happens in event handlers (`onAdminPanel`, `onDomainResolving`), not in `register()`. The empty overrides served no purpose since the parent `ServiceProvider` already provides the method. The two other Boot files were left as-is: - `src/Boot.php` — has a real `register()` implementation (module paths + search singleton) - `Service/Boot.php` — has no `register()` method at all

Charon added 1 commit 2026-03-24 16:41:47 +00:00

refactor: remove empty register() methods in Boot classes 8b173461af

These Boot classes use the event-driven $listens pattern where
registration happens in event handlers (onAdminPanel, onDomainResolving),
not in register(). The empty overrides served no purpose since the parent
ServiceProvider already provides the method.

Fixes #17

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin feat/clean-empty-register:feat/clean-empty-register

git checkout feat/clean-empty-register

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout dev

git merge --no-ff feat/clean-empty-register

git checkout feat/clean-empty-register

git rebase dev

git checkout dev

git merge --ff-only feat/clean-empty-register

git checkout feat/clean-empty-register

git rebase dev

git checkout dev

git merge --no-ff feat/clean-empty-register

git checkout dev

git merge --squash feat/clean-empty-register