Commit graph

14 commits

Author SHA1 Message Date
Snider
89872c14a3
#1 from host-uk/feature/security-hardening
Security hardening for install scripts
2026-01-31 18:15:57 +00:00
unknown
15778b7a5f
fix: address CodeRabbit review feedback
- Separate local declaration from assignment to avoid masking errors (SC2155)
- Add exit code check after Homebrew installer execution
- Add exit code check after NodeSource setup script execution
- Add LASTEXITCODE check after Chocolatey installer execution

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 02:00:26 +11:00
unknown
d9a8fe279e
security: harden shell scripts with integrity verification
- Add SHA256 checksum verification to install-core.sh binary download
- Add version pinning (v0.1.0) to install-core.sh matching PowerShell version
- Use mktemp for secure temp files instead of predictable /tmp/core
- Add symlink detection to prevent directory traversal attacks
- Add GPG signature verification for git tags when available
- Add checksum verification for Go binary in install-deps.sh
- Add SHA384 signature verification for Composer installer
- Replace Invoke-Expression with download-verify-execute in install-deps.ps1
- Download Homebrew/NodeSource scripts to temp files before execution
- Add security documentation and warnings for external scripts

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 01:19:45 +11:00
unknown
05bd711219
fix: production quality improvements
- Add PowerShell 4.0+ version check at startup
- Add disk space check (100MB minimum) before install
- Add try/finally cleanup for download temp files (handles Ctrl+C)
- Fix PATH duplicate semicolons by trimming before append
- Update header with requirements documentation

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 00:54:45 +11:00
unknown
1248758d46
security: fix single percent detection and add fsutil to PowerShell
setup.bat:
- Fix percent sign detection to catch single % (not just %%)
- Use string substitution for reliable detection

install-core.ps1:
- Add fsutil reparsepoint query to Test-SecureDirectory
- Matches batch script's dual-layer detection approach
- Keep .NET attribute check as fallback

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 00:46:46 +11:00
unknown
7eead7d48a
security: expand character filtering and improve junction detection
- Add backtick and percent sign to blocked characters
- Use fsutil reparsepoint query for reliable symlink/junction detection
- Keep attribute check as fallback defense layer

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 00:40:58 +11:00
unknown
991bb45d44
security: address remaining vulnerabilities from security review
install-core.ps1:
- Add Test-SecureDirectory and New-SecureDirectory to mitigate TOCTOU races
- Add Test-GitTagSignature for GPG verification of git tags
- Make ACL failures fatal for temp directories with retry logic
- Use precise PATH matching instead of substring contains
- Add unique GUID suffix to temp file names
- Document security controls and known limitations in header

setup.bat:
- Validate LOCALAPPDATA is within USERPROFILE
- Reject paths with invalid shell characters
- Add symlink detection for install directory
- Use delayed expansion variables for path safety

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 00:29:32 +11:00
unknown
c27158066e
security: harden install script against supply chain attacks
- Add SHA256 hash verification for downloaded binaries
- Pin to specific version (v0.1.0) instead of dev tag
- Validate LOCALAPPDATA is within user profile
- Detect symlink attacks on install directory
- Set restrictive ACL (owner-only) on temp build directories
- Validate PATH entries before modification
- Improve error handling with specific exception types

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 00:20:37 +11:00
unknown
53a2617fb8
refactor: use try/finally for Push-Location cleanup
Ensures Pop-Location is always called, even if Write-Err exits early.
Makes the cleanup pattern consistent and easier to maintain.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 00:11:34 +11:00
unknown
2e034f43f2
fix: add error handling and cleanup to install scripts
- Add git prerequisite check before cloning
- Check $LASTEXITCODE after git clone and go build
- Wrap build logic in try/finally for guaranteed temp cleanup
- Add error check after core setup command in batch file
- Show warning if core doctor reports issues

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 00:07:45 +11:00
unknown
86a80ec2e1
fix: Windows compatibility for install scripts
- Use Join-Path for reliable path handling in PowerShell
- Replace fragile New-TemporaryFile with GetTempPath + GUID
- Enable delayed expansion in batch for reliable errorlevel checks
- Add call statements for proper subprocess error propagation
- Verify core.exe exists before running commands
- Update repo reference and build path

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 00:00:23 +11:00
Snider
e7ee34ec5f chore: add .core/ to gitignore
Core CLI cache directory should not be tracked.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-28 15:19:11 +00:00
Snider
64bf2e281e feat: add installation scripts for cross-platform setup
- Add Makefile for make-based workflow
- Add setup.sh / setup.bat for one-command bootstrap
- Add scripts/install-deps.sh for macOS/Linux dependencies
- Add scripts/install-deps.ps1 for Windows (Chocolatey)
- Add scripts/install-core.sh to build/download core CLI
- Add scripts/install-core.ps1 for Windows
- Update README with installation instructions

Developers can now run:
  macOS/Linux: ./setup.sh (or make setup)
  Windows: .\setup.bat (as Admin)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-28 14:57:30 +00:00
Snider
71e8c1b2ef feat: initial developer workspace setup
- Add repos.yaml registry for all host-uk packages
- Add packages/ directory with .gitkeep (contents git-ignored)
- Add README with quickstart and prerequisites
- Add CLAUDE.md for AI-assisted development

Use `core setup` to clone all repos into packages/

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-28 14:50:45 +00:00