chore: discovery scan — 31 improvement issues created (closes #2) #35

Merged

Charon merged 1 commit from chore/issue-2-discovery-scan into main

2026-02-21 01:22:47 +00:00

Clotho commented

2026-02-21 01:04:42 +00:00

Member

Summary

This PR closes issue #2 (discovery scan). A thorough scan of the php-mcp codebase was performed and 31 improvement issues were created on forge.lthn.ai.

Issues Created

12 test coverage issues — untested services (ToolRegistry, AuditLogService, CircuitBreaker, DataRedactor, McpHealthService, McpMetricsService, McpWebhookDispatcher, OpenApiGenerator, ToolRateLimiter, AgentSessionService, AgentToolRegistry) and the QueryDatabase tool (#4–#15)
4 refactoring issues — AST SQL parser, ToolResult DTO, PHPStan fixes, Boot.php extraction (#16–#19)
4 infrastructure issues — missing YAML configs, PHPStan setup, CI security tests, result streaming (#20–#22, #31)
6 feature issues — query templates, schema tools, data export, caching, history, validation (#23–#26, #32–#33)
3 security review issues — suspicious query monitoring, ContentTools review, commerce tools review (#27–#29)
1 documentation issue — ContentTools and commerce tool docblocks (#30)
1 roadmap issue — master checklist for production readiness (#34)

Key Findings

Missing YAML configs (#20) — ToolRegistry expects resources/mcp/servers/*.yaml files that don't exist, blocking the service
No PHPStan (#21) — Static analysis not installed; 13+ services have type hint gaps
Security reviews needed (#28, #29) — ContentTools (22KB) and commerce tools lack security documentation and review
No CI security regression (#22) — Security fixes could be accidentally reverted without automated checks
13 untested services — Core infrastructure (CircuitBreaker, DataRedactor, AuditLogService chain verification) lacks tests

Test Plan

Discovery scan completed (READ-ONLY — no code modified)
31 issues created on forge.lthn.ai with appropriate labels
Roadmap issue #34 created with prioritised checklist
Discovery log added to docs/

🤖 Generated with Claude Code

## Summary This PR closes issue #2 (discovery scan). A thorough scan of the php-mcp codebase was performed and 31 improvement issues were created on forge.lthn.ai. ## Issues Created - **12 test coverage issues** — untested services (ToolRegistry, AuditLogService, CircuitBreaker, DataRedactor, McpHealthService, McpMetricsService, McpWebhookDispatcher, OpenApiGenerator, ToolRateLimiter, AgentSessionService, AgentToolRegistry) and the QueryDatabase tool (#4–#15) - **4 refactoring issues** — AST SQL parser, ToolResult DTO, PHPStan fixes, Boot.php extraction (#16–#19) - **4 infrastructure issues** — missing YAML configs, PHPStan setup, CI security tests, result streaming (#20–#22, #31) - **6 feature issues** — query templates, schema tools, data export, caching, history, validation (#23–#26, #32–#33) - **3 security review issues** — suspicious query monitoring, ContentTools review, commerce tools review (#27–#29) - **1 documentation issue** — ContentTools and commerce tool docblocks (#30) - **1 roadmap issue** — master checklist for production readiness (#34) ## Key Findings 1. **Missing YAML configs** (#20) — `ToolRegistry` expects `resources/mcp/servers/*.yaml` files that don't exist, blocking the service 2. **No PHPStan** (#21) — Static analysis not installed; 13+ services have type hint gaps 3. **Security reviews needed** (#28, #29) — ContentTools (22KB) and commerce tools lack security documentation and review 4. **No CI security regression** (#22) — Security fixes could be accidentally reverted without automated checks 5. **13 untested services** — Core infrastructure (CircuitBreaker, DataRedactor, AuditLogService chain verification) lacks tests ## Test Plan - [x] Discovery scan completed (READ-ONLY — no code modified) - [x] 31 issues created on forge.lthn.ai with appropriate labels - [x] Roadmap issue #34 created with prioritised checklist - [x] Discovery log added to docs/ 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Clotho added 1 commit 2026-02-21 01:04:43 +00:00

chore: record discovery scan results for issue #2

CI / PHP 8.2 (pull_request) Waiting to run

Details

CI / PHP 8.3 (pull_request) Waiting to run

Details

CI / PHP 8.4 (pull_request) Waiting to run

Details

CI / Assets (pull_request) Waiting to run

Details

217e9bbfb6

Automated scan of the php-mcp codebase identified 30 issues across:
- 12 missing test coverage gaps (services, tools)
- 4 refactoring opportunities (SQL parser, ToolResult DTO, PHPStan, Boot.php)
- 4 infrastructure chores (missing YAML configs, PHPStan setup, CI, streaming)
- 6 feature gaps (templates, schema tools, export, caching, history, validation)
- 3 security reviews required (suspicious query monitoring, ContentTools, commerce)
- 1 documentation gap

All issues created on forge.lthn.ai (issues #4–#34).
Roadmap summary at #34

Closes #2

Co-Authored-By: darbs-claude <developers@lethean.io>