refactor: add return type hints to all Workspace model relationships #18

New issue

Open

opened 2026-02-20 16:38:30 +00:00 by Clotho · 0 comments

Clotho commented

2026-02-20 16:38:30 +00:00

Member

Problem

Models/Workspace.php has many relationship methods with correct PHPDoc blocks but missing or inconsistent explicit PHP return type declarations. The Workspace model has 30+ relationships.

Impact

IDE autocompletion is degraded
Static analysis tools (PHPStan/Larastan) cannot infer correct types
Inconsistency with the project's strict typing standard

Acceptance Criteria

Add explicit return types to all relationship methods (e.g. HasMany, BelongsToMany, HasOne)
Verify PHPStan/Larastan passes at level 6+ after changes
No changes to runtime behaviour

Discovered during automated scan (issue #3)

## Problem `Models/Workspace.php` has many relationship methods with correct PHPDoc blocks but missing or inconsistent explicit PHP return type declarations. The Workspace model has 30+ relationships. ## Impact - IDE autocompletion is degraded - Static analysis tools (PHPStan/Larastan) cannot infer correct types - Inconsistency with the project's strict typing standard ## Acceptance Criteria - Add explicit return types to all relationship methods (e.g. `HasMany`, `BelongsToMany`, `HasOne`) - Verify PHPStan/Larastan passes at level 6+ after changes - No changes to runtime behaviour _Discovered during automated scan (issue #3)_