refactor: add return type hints to Workspace model scope methods #60

Open

Charon wants to merge 0 commits from feat/workspace-return-types into dev

Charon commented

2026-03-24 13:16:28 +00:00

Member

Summary

Add Builder parameter type and return type declarations to scopeActive() and scopeOrdered()
Add missing Illuminate\Database\Eloquent\Builder import
These were the only two methods in the Workspace model missing explicit type hints

Fixes #18

Test plan

vendor/bin/pint --dirty passes
Scope methods are simple query builder wrappers; existing tests cover their usage

## Summary - Add `Builder` parameter type and return type declarations to `scopeActive()` and `scopeOrdered()` - Add missing `Illuminate\Database\Eloquent\Builder` import - These were the only two methods in the Workspace model missing explicit type hints Fixes #18 ## Test plan - [x] `vendor/bin/pint --dirty` passes - Scope methods are simple query builder wrappers; existing tests cover their usage

This branch is already included in the target branch. There is nothing to merge.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin feat/workspace-return-types:feat/workspace-return-types

git checkout feat/workspace-return-types

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout dev

git merge --no-ff feat/workspace-return-types

git checkout feat/workspace-return-types

git rebase dev

git checkout dev

git merge --ff-only feat/workspace-return-types

git checkout feat/workspace-return-types

git rebase dev

git checkout dev

git merge --no-ff feat/workspace-return-types

git checkout dev

git merge --squash feat/workspace-return-types