core/mcp
8
0
Fork 0
Code Issues 4 Pull requests 2 Projects Releases Packages Wiki Activity Actions

[agent/codex:gpt-5.4-mini] Read ~/spec/code/core/mcp/RFC.md fully. Find ONE feature des... #18

Open
Virgil wants to merge 0 commits from agent/read---spec-code-core-mcp-rfc-md-fully into dev
pull from: agent/read---spec-code-core-mcp-rfc-md-fully
merge into: core:dev
Conversation 3 Commits - Files changed -
Virgil commented 2026-04-01 09:56:08 +00:00
Member
Copy link

Task

Read ~/spec/code/core/mcp/RFC.md fully. Find ONE feature described in the specs that is NOT implemented in the code. Implement it. If no missing features, update the code against the AX design principles in ~/spec/rfc/core/RFC-CORE-008-AGENT-EXPERIENCE.md instead. Commit when done.

Agent: codex:gpt-5.4-mini
Commits: 1
Branch: agent/read---spec-code-core-mcp-rfc-md-fully

Auto-created by core-agent dispatch system.
Co-Authored-By: Virgil virgil@lethean.io

## Task Read ~/spec/code/core/mcp/RFC.md fully. Find ONE feature described in the specs that is NOT implemented in the code. Implement it. If no missing features, update the code against the AX design principles in ~/spec/rfc/core/RFC-CORE-008-AGENT-EXPERIENCE.md instead. Commit when done. **Agent:** codex:gpt-5.4-mini **Commits:** 1 **Branch:** `agent/read---spec-code-core-mcp-rfc-md-fully` --- Auto-created by core-agent dispatch system. Co-Authored-By: Virgil <virgil@lethean.io>
Virgil commented 2026-04-01 09:56:14 +00:00
Author
Member
Copy link

Tests Passed — Merge Failed

go test ./... passed but merge failed

## Tests Passed — Merge Failed `go test ./...` passed but merge failed
Virgil commented 2026-04-01 09:56:20 +00:00
Author
Member
Copy link

Tests Passed — Merge Failed

go test ./... passed but merge failed

## Tests Passed — Merge Failed `go test ./...` passed but merge failed
Virgil commented 2026-04-01 09:56:20 +00:00
Author
Member
Copy link

Needs Review

Merge conflict persists after rebase. Auto-merge gave up after retry.

Labelled needs-review for human attention.

## Needs Review Merge conflict persists after rebase. Auto-merge gave up after retry. Labelled `needs-review` for human attention.
Co-Authored-By: Virgil <virgil@lethean.io>
Keeps the registry surface tighter by removing the unused splitTagSeq helper and updating the test to cover the production splitTag helper directly.

Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Auto-discovers process.Service and ws.Hub instances already registered in Core so the MCP service factory exposes the matching tool groups without extra manual wiring.

Co-Authored-By: Virgil <virgil@lethean.io>
Implement agentic_dispatch_issue and agentic_pr for Forge issue-driven workflows, and track issue-specific branch metadata in agent workspaces.

Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Expose all languages already recognized by lang_detect in lang_list, and keep the two paths synchronized through a shared catalog.

Co-Authored-By: Virgil <virgil@lethean.io>
Use the Core context for forwarded IPC channel events and expose a session-level notification helper that the broadcast path reuses. This keeps the notification API more symmetric and avoids dropping context during IPC forwarding.

Co-Authored-By: Virgil <virgil@lethean.io>
Generate real session IDs and retain chat/activity/session state in the IDE subsystem so session_create, chat_history, session_list, and dashboard tools return useful local data before the backend responds.

Co-Authored-By: Virgil <virgil@lethean.io>
Headless IDE sessions now keep working for chat history, session listing, session creation, plan status, dashboard activity, dashboard metrics, and build lookups. The Laravel bridge is still used when available, but it is no longer a hard dependency for the local cache-backed tools.

Co-Authored-By: Virgil <virgil@lethean.io>
Use the underlying MCP notification path for session broadcasts so fresh sessions receive notifications without requiring a prior log-level handshake.

Add a regression test that verifies broadcast delivery on a connected session.

Co-Authored-By: Virgil <virgil@lethean.io>
Wire the agentic subsystem into the shared MCP notifier so workspace
completion, blocked, and status transitions are broadcast to clients.
Also keep resumed workspaces from leaving stale running state after the
process exits.

Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Use Stat() for file_exists and sort directory listings for deterministic output.

Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Advertise and emit build.start when a bridged build enters a running state, alongside the existing complete/fail lifecycle events.

Co-Authored-By: Virgil <virgil@lethean.io>
Tighten MCP session notification dispatch and add coverage for harvest.complete payloads.

Co-Authored-By: Virgil <virgil@lethean.io>
Keep channel emitters, provider metadata, and capability advertising in sync by sharing the same constants across the MCP subsystems.

Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Allow the IDE bridge to register multiple observers so the IDE and brain subsystems can both react to inbound Laravel messages. Brain recall notifications now fire from the bridge callback with the real result count instead of the request path, and the brain provider follows the same async notification flow.

Co-Authored-By: Virgil <virgil@lethean.io>
Add support for plans://, sessions://, and content:// resources via the MCP API controller instead of returning 501 for every request.\n\nCo-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Update stale MCP service and CLI descriptions so they match the current runtime shape, and log the actual bound TCP address when listening on an ephemeral port.

Co-Authored-By: Virgil <virgil@lethean.io>
Core MCP already implements the RFC-shape functionality; this pass tightens the AX surface by adding usage-example comments to public constructors and config helpers.

Co-Authored-By: Virgil <virgil@lethean.io>
Guard the notification broadcast helpers against nil Service and nil server values so they degrade to no-ops instead of panicking. Add coverage for zero-value and nil-server use.

Co-Authored-By: Virgil <virgil@lethean.io>
Make notification broadcasting tolerant of a nil context and make TCP transport fall back to DefaultTCPAddr when no address is supplied.

Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Remove the duplicate brain-local notifier interface and use the shared pkg/mcp Notifier type directly. Also align stale test comments with the current Options constructor API.

Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Reorder subsystem notification wiring so channel callbacks are available before tool registration, and add usage-example comments to the public notification DTOs and helpers.

Co-Authored-By: Virgil <virgil@lethean.io>
Return copies from service accessors and ignore nil subsystems during construction to keep the MCP service API stable and AX-friendly.

Co-Authored-By: Virgil <virgil@lethean.io>
Align the IDE bridge and brain subsystem public types with the repo's AX-style comment convention by adding concrete usage examples for bridge messages, DTOs, and helper callbacks.

Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Make the func-based channel wiring contract explicit instead of relying on an anonymous interface inside New(). This keeps the extension point discoverable and aligned with the repository's AX-style API clarity.

Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
This branch is already included in the target branch. There is nothing to merge.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin agent/read---spec-code-core-mcp-rfc-md-fully:agent/read---spec-code-core-mcp-rfc-md-fully
git switch agent/read---spec-code-core-mcp-rfc-md-fully

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch dev
git merge --no-ff agent/read---spec-code-core-mcp-rfc-md-fully
git switch agent/read---spec-code-core-mcp-rfc-md-fully
git rebase dev
git switch dev
git merge --ff-only agent/read---spec-code-core-mcp-rfc-md-fully
git switch agent/read---spec-code-core-mcp-rfc-md-fully
git rebase dev
git switch dev
git merge --no-ff agent/read---spec-code-core-mcp-rfc-md-fully
git switch dev
git merge --squash agent/read---spec-code-core-mcp-rfc-md-fully
git switch dev
git merge --ff-only agent/read---spec-code-core-mcp-rfc-md-fully
git switch dev
git merge agent/read---spec-code-core-mcp-rfc-md-fully
git push origin dev
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
needs-review

   
needs-review

   
needs-review

   
needs-review

   
needs-review

   
needs-review

   
needs-review
  
athena
Assign to Athena AI agent (M3 Ultra)

  
athena-gemini
Dispatch to Gemini CLI on M3 Ultra

  
audit
Code audit task

  
clotho
Assign to Clotho AI agent for processing

  
clotho-gemini
Dispatch to Gemini CLI on darbs (AU)

  
codex
Dispatch to Codex CLI on gateway for analysis

  
darbs-claude
Dispatch to Claude on darbs (AU)

  
security
Security review task

  
wiki
Documentation/wiki update

No labels
needs-review
needs-review
needs-review
needs-review
needs-review
needs-review
needs-review
athena
athena-gemini
audit
clotho
clotho-gemini
codex
darbs-claude
security
wiki
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

-

Dependencies

No dependencies set.

Reference
core/mcp!18
No description provided.